gh-134160: "First extension module" tutorial improvements #144183
+39
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass -v to pip, so compiler output is visible - Move the call ``spam.system(3)`` up so that error handling is tested right after it's added - Use `PyUnicode_AsUTF8AndSize` as `PyUnicode_AsUTF8` is not in the Limited API. - Add a footnote about embedded NULs.
Member
Author
|
I'll merge around Friday if there are no objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run through the tutorial with a mentee (best way to test tutorials btw!) and found some things to improve.
spam.system(3)up so that error handling is tested right after it's addedPyUnicode_AsUTF8AndSizeasPyUnicode_AsUTF8is not in the Limited API.📚 Documentation preview 📚: https://cpython-previews--144183.org.readthedocs.build/